-
-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix filter-prod flag including all workspace pkgs #4957
Conversation
pnpm@f48d46e appears to have surfaced a regression where the exclusion filter for workspace root broke was inserted without followProdDepsOnly. i guess we didn't notice earlier because filterProd together with workspaceRoot is an edge-case ;)
💖 Thanks for opening this pull request! 💖 |
I am not sure what the issue is. Add a test, please. |
Any updates on this?
builder is added as devDependency in |
Also will it be fine if I create a new PR for this issue? |
ok, just add a test. |
I have wrote the test case but getting lint errors in untouched files while pushing the changes. Should I ignore that lint rule for the project? |
Maybe you need to run |
covered by #5437 |
f48d46e appears to have surfaced a regression where the exclusion filter for workspace root broke was inserted without followProdDepsOnly. i guess we didn't notice earlier because filterProd together with workspaceRoot is an edge-case ;)